Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Fix Client: IsOptsWithPrefix returns false even if WithPrefix() is included #14187

Conversation

spzala
Copy link
Member

@spzala spzala commented Jul 3, 2022

Cherry pick of #14182 on release-3.5.

#14182: Client: fix check for WithPrefix op

Make sure that WithPrefix correctly set the flag, and add test.
Also, add test for WithFromKey.

fixes etcd-io#14056

Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
@spzala spzala force-pushed the automated-cherry-pick-of-#14182-upstream-release-3.5 branch from 92ac821 to 4df61af Compare July 3, 2022 03:33
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @spzala

@ahrtr ahrtr merged commit 57c1d92 into etcd-io:release-3.5 Jul 3, 2022
@spzala
Copy link
Member Author

spzala commented Jul 3, 2022

Thank you @ahrtr !!

@spzala spzala mentioned this pull request Jul 6, 2022
16 tasks
@serathius serathius changed the title Automated cherry pick of #14182 [3.5] Fix Client: IsOptsWithPrefix returns false even if WithPrefix() is included Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants